[Others]remove fa4 requirement#7143
Merged
zoooo0820 merged 2 commits intoPaddlePaddle:developfrom Apr 13, 2026
Merged
Conversation
|
Thanks for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7143 +/- ##
==========================================
Coverage ? 73.88%
==========================================
Files ? 383
Lines ? 53591
Branches ? 8406
==========================================
Hits ? 39595
Misses ? 11303
Partials ? 2693
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
PaddlePaddle-bot
left a comment
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
📋 Review 摘要
PR 概述：移除 flash_mask (FA4) 依赖以避免某些 Docker 环境下的依赖冲突
变更范围：requirements.txt
影响面 Tag：[Others]
📝 PR 规范检查
问题描述：
- PR 描述存在拼写错误：
remote→remove - PR 描述缺少关键信息，未说明：
- 移除 FA4 后的回退策略（FA3/FA2）
- 对 SM100+ GPU 用户的功能影响
- 具体是哪些 Docker 环境会有冲突
描述建议（可直接复制）：
## Motivation
Remove flash_mask requirements to avoid dependency conflicts in some Docker image environments.
**Note**: After removal, systems with SM100+ GPUs will fall back to Flash Attention V3 (if SM>=89) or V2.
## Modifications
- Comment out flash_mask dependency in requirements.txt
## Impact
- No runtime crash: code has try-except protection
- SM100+ GPUs: FA4 (Flash Attention V4) will not be available, will fall back to FA3/FA2
- Related tests (`test_flash_encoder_attn_fwd`, `test_fa4`) will be skipped问题
| 级别 | 文件 | 概述 |
|---|---|---|
| 🟡 建议 | requirements.txt:50 |
移除 FA4 依赖后应补充说明文档或迁移指南 |
总体评价
变更本身不会导致运行时崩溃（代码已有 try-exct 保护），但 PR 描述需要补充完整的影响说明，以便用户了解变更后果。
qingqing01
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
remove flash-mask requiements to avoid conflict in some docker image environments.
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.